- 11 Dec, 2025 13 commits
-
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
- Add YouTube video link: Moqui MCP 2025-12-08 - Document what demo shows: screen navigation, data analysis, business insights - Highlight key success: color availability discovery (blue/black only) - Include technical details: GLM-4.6, MCP v2.0.1, containerized environment - Validate that MCP integration enables meaningful AI-ERP interaction Demo provides real-world evidence of capabilities working in practice.
Ean Schuessler committed -
- Add prominent WARNING: THIS DOG MAY EAT YOUR HOMEWORK - Document all security vulnerabilities and attack vectors - Explain how LLM with ADMIN access can destroy the system - Provide mandatory safety requirements (containers, limited users, isolation) - Remove irresponsible 'production-ready' language - Add message to AI creators about warm fuzzies being dangerous This MCP implementation gives LLMs god-mode access to entire ERP system. Extreme caution required - never deploy with ADMIN access in production.
Ean Schuessler committed
-
- 08 Dec, 2025 4 commits
-
-
- Complete project overview and feature description - Quick start guide with installation and usage instructions - Tool examples for catalog, order, customer, and pricing management - Configuration details for server and security setup - Testing guide with test suite structure and examples - Development documentation with project structure - API reference for MCP protocol methods - Security considerations and performance notes - Troubleshooting guide for common issues - Contributing guidelines and license information
Ean Schuessler committed -
Ean Schuessler committed
-
- Add comprehensive logging for MCP service calls (EXECUTESCREEN, SCREENASTOOL, ToolsCall) - Update instructions to include Product_EditPrices tool for price checking - Change default render mode to 'html' for better screen output - Temporarily disable visit.update() to reduce database overhead during debugging - Improve parameter passing for screen execution tools
Ean Schuessler committed -
- Remove duplicate code blocks for screen tool execution - Simplify protocolMethodMappings to directly route MCP methods to services - Clean up tools/call special handling with single, unified flow - Preserve all existing functionality for recursive screen discovery
Ean Schuessler committed
-
- 07 Dec, 2025 13 commits
-
-
- Fixed line 153: protocolMethodMappings[name]} → protocolMethodMappings[name]} - Resolves 'Unexpected input: }' @ line 160, column 17' compilation error - Allows service to compile and run properly - Session handling issue still needs investigation
Ean Schuessler committed -
- Simplify tool name decoding logic to handle different naming conventions - Remove complex regex patterns that may cause Groovy compilation issues - Add debug logging to track decoding behavior - Tool names like screen_PopCommerce_screen_PopCommerceAdmin_Catalog.Product_FindProduct should now decode correctly - This should resolve 'Service returned null result' errors for complex screen tools
Ean Schuessler committed -
- Fixed line 200: result.result = [...] → result = [...] - Fixed line 310: result.result = [...] → result = [...] - Ensures all MCP services return flat structure for JSON-RPC response - Combined with callMcpService fix to eliminate all double nesting issues - Should resolve opencode client 'Typeundefined is not an object (evaluating result.content)' error - MCP response now has correct structure: result.content = [...] direct access
Ean Schuessler committed -
- tools/call was incorrectly nesting ScreenAsMcpTool result: result.result = [content: ...] - ScreenAsMcpTool already returns correct structure: result = [content: ...] - Creates nested result.result.result which breaks MCP spec and client parsing - Fix: Extract content directly from serviceResult.result instead of nesting - Resolves opencode client error: 'Typeundefined is not an object (evaluating result.content)' - Now result.content correctly accesses content array as expected by MCP clients
Ean Schuessler committed -
- Change default renderMode from 'html' to 'text' for screen tools - Reduces response size from 89KB to 5.6KB for FindProduct screen - Returns clean table data instead of complex HTML forms with JavaScript - Makes screen tool output LLM-friendly and resolves opencode client parsing issues - Text format shows actual data in readable table format perfect for AI consumption
Ean Schuessler committed -
- Previous edit incorrectly placed variable definition inside JSON map literal - Move actualResult assignment outside JsonOutput.toJson call - Resolves build error: Unexpected input '(' @ line 537Ean Schuessler committed -
- SSE handler was returning generic status message instead of actual service result - Extract actualResult from service response (same as regular HTTP handler) - Tool calls now return proper content including screen execution results - Fixes issue where tools worked but results didn't reach opencode client
Ean Schuessler committed -
- Move list#Tools recursive screen processing logs to debug level - Move ResourcesList entity discovery logs to debug level - Keep high-level summary logs at info level for operational visibility - Significantly reduces log noise during normal MCP operations
Ean Schuessler committed -
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
Ean Schuessler committed
-
- 05 Dec, 2025 5 commits
-
-
- Add tools/list, tools/call, resources/list, resources/read, and ping methods - Include proper input schemas and descriptions for each method - Add debug logging for tools list generation - Position standard methods at beginning of list for first-page visibility
Ean Schuessler committed -
- Fix XML parsing to use proper Moqui MNode attribute access methods - Add screen definition (sd) fallback to extract actual screen locations - Resolves issue where deeper-level cross-component screens were missing - Now discovers 536 tools instead of 199 (full recursive discovery) - Correctly handles PopCommerce Catalog → SimpleScreens Product → FindProduct - Maintains security model while enabling arbitrary depth screen discovery
Ean Schuessler committed -
- Remove hard-coded PopCommerce filter from list#Tools service - Add proper recursive screen discovery using processScreenWithSubscreens function - Update MCP routing to use list#Tools instead of mcp#ToolsList for tools/list endpoint - Now discovers ALL screens from AuthzCheckView instead of just PopCommerce - Implements proper hierarchical tool naming with dot notation for first-level subscreens - Supports cross-component screen discovery (PopCommerce → SimpleScreens, etc.) - MCPJam inspector can now connect and discover 100+ screen tools This resolves the issue where tools/list returned 0 tools instead of discovering all accessible screens recursively across all components.
Ean Schuessler committed -
## Database Lock Contention Resolution (80-90% improvement) **Problem**: 88+ second database lock waits with AT_ENTITY:moqui.server.Visit **Solution**: Remove unnecessary Visit entity access and implement throttled updates ### Key Changes: - **Removed manual Visit creation fallbacks** - Eliminated duplicate code paths - **Made services stateless** - Removed updateSessionActivity() calls - **Added throttled session updates** - 30-second intervals vs every 5 seconds - **Implemented per-session synchronization** - Prevent concurrent updates - **Disabled authz during Visit access** - Reduces automatic tracking ## MCP Session State Bug Fix **Problem**: Sessions stuck in INITIALIZING state, causing "Session not initialized" errors **Root Cause**: initialize() method never transitioned sessions to INITIALIZED state **Solution**: Proper state transition after successful initialization ### Technical Changes: - **EnhancedMcpServlet.groovy**: Added session state INITIALIZED transition - **McpServices.xml**: Removed Visit.update() calls, disabled authz during operations - **VisitBasedMcpSession.groovy**: Removed session activity updates from sendMessage() ## Results:
Ean Schuessler committed
Lock waits reduced from 88+ seconds to 5-6 seconds (80-90% improvement)
MCP protocol compliance restored - no more validation errors
Session lifecycle working correctly - immediate usability after initialization
All MCP tools and functionality operational
Maintains security model while eliminating performance bottlenecks. -
Ean Schuessler committed
-
- 04 Dec, 2025 5 commits
-
-
- Fixed notifications/initialized to return 202 Accepted instead of 204 No Content - Added comprehensive MCP method implementation (prompts, roots, sampling, etc.) - Enhanced notification handling with proper session state transitions - Updated protocol version support to include 2025-11-25 with backward compatibility - Improved error handling and logging for debugging MCP connections - Added subscription tracking and message storage for advanced features - Fixed Accept header validation per MCP 2025-11-25 specification Resolves the critical two-step handshake issue where MCP Inspector was not receiving the correct response for notifications/initialized.
Ean Schuessler committed -
- Add notification queue mechanism in EnhancedMcpServlet - Register servlet instance for service access - Implement queueNotification() method for async notifications - Add notification delivery in JSON-RPC responses - Include notifications in both tools/list and tools/call services - Add execution timing and success metrics - Handle notification errors gracefully - Support both polling and SSE delivery methods This completes the MCP server notification system allowing real-time communication about tool execution status and metrics.
Ean Schuessler committed -
- Remove sessionId field from initialize response body (not in MCP spec) - Set Mcp-Session-Id header in initialize response using visit ID - Maintain proper header setting for other methods that return sessionId - Ensure MCP protocol compliance for initialization flow
Ean Schuessler committed -
- Allow notifications/initialized without session ID header as it completes initialization process - Add fallback to use visit ID as session ID for both initialize and notifications/initialized methods - Maintain proper session state management and validation for other methods - Follow MCP protocol specification for initialization flow
Ean Schuessler committed -
- Remove 'Moqui screen: component://...' prefix from descriptions - Use clean screen titles as descriptions instead - Fully decode screen paths from encoded tool names using established conventions - Tool names contain all necessary information: _ → /, . indicates XML boundary - Makes MCP tool list cleaner and more logical
Ean Schuessler committed
-
