Ean Schuessler / mo-mcp

Ean Schuessler committed 2026-01-13 18:36:41 -0600

Error Handling:
- Check ec.message.hasError() before and after transaction flush
- Return "status": "error" with error messages instead of false success
- Prevents silent failures when constraint violations occur (e.g., invalid Party IDs)

Dropdown Metadata:
- Capture static dropdown options from sri.getFieldOptions()
- Capture dynamic-options config (transition, serverSearch, minLength, parameterMap)
- Enables model to understand searchable dropdowns vs static lists

This improves the model's ability to:
1. See clear error messages when operations fail
2. Understand dropdown behavior (server search vs static)
3. Take corrective action based on error feedback

Ean Schuessler committed 2026-01-13 18:29:36 -0600

Fix path references in data files to use forward slash notation:
- /PopCommerce/PopCommerceAdmin.Catalog.Product → /PopCommerce/PopCommerceAdmin/Catalog/Product
- /PopCommerce/PopCommerceAdmin.Order.FindOrder → /PopCommerce/PopCommerceAdmin/Order/FindOrder
- /PopCommerce/PopCommerceRoot.Customer → /PopCommerce/PopCommerceRoot/Customer

Also updates:
- AGENTS.md: Remove completed path delimiter test items
- Fix wiki page path references (SimpleScreens.Root → SimpleScreens/Root)

Aligns with slash-based path system adopted in earlier refactor.

Ean Schuessler committed 2026-01-13 15:10:30 -0600

Ean Schuessler committed 2026-01-13 13:32:19 -0600

- EnhancedMcpServlet: Reuse existing ExecutionContext from MoquiAuthFilter instead of creating duplicate
- EnhancedMcpServlet: Removed manual EC destruction - auth filter handles cleanup
- McpServices: Skip EntityFind objects in serialization (they're query definitions, not data)
- McpServices: Make patchScreenRenderForNullFieldNode static for call from static context
- McpServices: Remove renderedContent for renderMode 'mcp' to avoid JSON duplication/truncation
- AGENTS.md: Document rebuild.sh script usage
- mcp.sh: Use hidden session file (.mcp_session_USER)
- rebuild.sh: Fix shell syntax error and add startup wait logic

Ean Schuessler committed 2026-01-13 13:28:59 -0600

Move verbose per-request logging (request body, session management,
SSE connections, method processing) from INFO to DEBUG level.
Keep INFO for significant events like new Visit creation.

Ean Schuessler committed 2026-01-13 00:43:23 -0600

- Terse mode: 50 items/5000 chars (from 30/2000)
- Non-terse mode: 1000 items/50000 chars (from 250/5000)
- Prioritizes operational data completeness over token savings
- Prevents "ghost errors" from arbitrary data dropping

Ean Schuessler committed 2026-01-13 00:14:20 -0600

- Add field types: radio, display, link, file-upload, hidden
- Add link types: action, delete, external, button
- Add action types: service-action, form-action, screen-transition, delete-action
- Enhance parameter metadata with type, required, defaultValue
- Classify actions automatically by service/name patterns
- Update narrative builder to describe action/link types
- Defensive parameter extraction with reflection fallbacks

Ean Schuessler committed 2026-01-12 23:49:56 -0600

- Safe navigation of formNode and fieldNode attributes using ?parent
- Fallback to empty string for null field values in display/text macros
- Use getActiveScreenDef() for screen name resolution in formListWidget
- Prevents NullPointerException in EditPrices and other list screens.

Ean Schuessler committed 2026-01-12 23:39:23 -0600

- Resolve NonHashException in macros by avoiding .add() on sequences.
- Fix 'Maps with null keys' JSON error by ensuring string keys.
- Stabilize form macros with null-safe checks.
- Update McpServices and CustomScreenTestImpl for better semantic data handling.

Ean Schuessler committed 2026-01-12 23:30:44 -0600

Extract core MCP logic into modular services (ResolveScreenPath, RenderScreenNarrative, ExecuteScreenAction) and update screen path conventions to use slash notation (e.g., /PopCommerce/Product) instead of dot notation. This aligns MCP navigation with browser URLs and improves path resolution reliability.

- Split McpServices.xml into specialized services for better maintainability
- Update DefaultScreenMacros.mcp.ftl to generate slash-based links
- Update prompts and documentation to reflect new path convention
- Enhance CustomScreenTestImpl to support slash path parsing
- Add AGENTS.md documenting self-guided narrative screens architecture

Ean Schuessler committed 2026-01-12 22:49:06 -0600

- Create UiNarrativeBuilder class for structured, story-like UI descriptions
  - screen: 50-80 words describing current state
  - actions: 80-120 words with exact tool invocation examples
  - navigation: 30-40 words for navigating to related screens
  - notes: 30-50 words for truncation, permissions, constraints

- Enhance mcp.ftl macros to capture semantic metadata
  - form-single: Track field names, types, validation rules
  - form-list: Capture totalItems, displayedItems, truncated flags
  - Store metadata in mcpSemanticData for narrative generation

- Deprecate DefaultScreenMacros.json.ftl
  - Update MoquiConf.xml to map both mcp and json to mcp.ftl
  - Remove redundant 218-line template with no semantic capture

- Integrate uiNarrative into BrowseScreens service
  - Generate narrative using UiNarrativeBuilder
  - Include uiNarrative in result map
  - Provide screenDef for context

- Remove redundant semantic state extraction
  - Delete fallback logic that extracted forms/lists from screen definition
  - Rely exclusively on mcpSemanticData captured by macros

- Improve smart truncation in serializeMoquiObject
  - terse mode: 10 items, 200 char strings
  - non-terse mode: 50 items, no string truncation (fixed bug)
  - Add _hasMore flag to truncated data metadata

- Fix CustomScreenTestImpl postRenderContext capture
  - Capture context before pop to preserve mcpSemanticData

Ean Schuessler committed 2026-01-09 21:12:43 -0600

Ean Schuessler committed 2026-01-09 16:57:09 -0600

Ean Schuessler committed 2026-01-05 13:57:13 -0600

Ean Schuessler committed 2026-01-02 18:57:48 -0600

Ean Schuessler committed 2026-01-02 18:45:53 -0600

- Remove McpScreenDoc entity and mapping layer
- Use screen paths directly as WikiPage.pagePath
- Fix historySeqId from string "01" to numeric "1"
- Fix DbResourceFile fileData to use CDATA for complex content
- Add wiki descriptions to BrowseScreens subscreens
- Update BrowseScreens to query WikiPage directly by screenPath
- Remove duplicate/corrupt data entries from McpScreenDocsData.xml

Ean Schuessler committed 2026-01-02 18:30:38 -0600

- Update build.gradle: jakarta.servlet-api:6.1.0
- Update EnhancedMcpServlet.groovy: Jakarta imports and servlet attributes
- Update WebFacadeStub.groovy: Complete Jakarta migration
  - New Servlet 6.0 methods (getRequestId, getProtocolRequestId, getServletConnection)
  - Removed deprecated methods (getSessionContext, getRealPath, etc.)
  - New sendRedirect(String, int, boolean) overload
- Update TestHealthServlet.java: Jakarta servlet imports

Aligns with upstream framework migration to Jakarta EE.

Ean Schuessler committed 2026-01-02 14:02:15 -0600

- Load McpPromptsData.xml seed data for prompt templates
- Add data load to component.xml

Ean Schuessler committed 2025-12-31 12:46:34 -0600

- Fix inputSchema properties to use quoted string keys for proper JSON Schema format
- Remove debug logging added for Accept header troubleshooting
- Remove unnecessary tools/list workaround in mcp#ToolsCall service
- The properties field in inputSchema must be a record/object, not an array
- All 6 tool schemas now properly defined with string keys: "path", "action", "renderMode", "parameters", "query", "name", "arguments"

Ean Schuessler committed 2025-12-31 12:46:11 -0600

Ean Schuessler committed 2025-12-30 10:37:19 -0600

- Delegate Basic Auth to MoquiAuthFilter instead of inline handling
- Fix Accept header validation to use OR instead of AND condition
- Enhanced JSON macros with form rendering and dot notation link paths
- Add query parameter stripping for screen paths
- Update MCP instructions to use dot notation for screen paths
- Remove obsolete McpFilter implementation

Ean Schuessler committed 2025-12-29 16:01:06 -0600

The submit button rendering code I added needs sri.getFormNode() which requires a form
node to be in context. When rendering form-list rows with individual submit fields,
the form node is not available causing FTL template errors. This is expected
behavior - actions are still extracted via screen definition (renderMode=mcp), which is the
intended metadata mechanism.

Ean Schuessler committed 2025-12-23 17:37:31 -0600

Ean Schuessler committed 2025-12-23 15:19:49 -0600

- Revert to CustomScreenTestImpl instead of broken ec.screen.render() call
- Remove duplicate screenUrl variable declaration
- Fix transition method calls: hasTransitions() → hasTransition(null), getAllTransitions() → getTransitionList()
- Simplify rendering path to always use CustomScreenTestImpl for both action and browse modes

This restores working screen rendering functionality that was broken during the
action execution implementation work (commit 0fc4e236). The ec.screen.render()
API doesn't exist on ScreenFacadeImpl, causing RENDER_EXCEPTION for all screens.

Ean Schuessler committed 2025-12-23 15:01:54 -0600

Remove mock/test session requirement when action != null
This allows database updates to persist when action is executed through MCP.

Ean Schuessler committed 2025-12-23 14:03:04 -0600

- Parse screen definition and find transitions directly
- Execute transitions (service calls) instead of queuing actions
- Handle action types: null (browse), submit (form), create, update, or named transition
- For 'submit' action: pass parameters to screen render for form processing
- For other actions: call service directly and return result
- Add actionResult to browse response with status and service details
- This bypasses CSRF/session limitations by executing transitions at service layer

Enables models to actually trigger state changes via MCP instead of just queuing actions.

Ean Schuessler committed 2025-12-23 13:35:05 -0600

- Add optional action parameter for processing before rendering
- Action values: null (browse), submit (form), create, update, or transition name
- Action processing queued and passed through to screen rendering
- Add actionResult and actionError to browse response
- Update tool schema to expose action parameter
- Keep moqui_render_screen for direct screen access

This enables models to trigger form submissions and transitions through browse_screens.

Ean Schuessler committed 2025-12-23 13:16:50 -0600

- Add renderMode parameter (default: 'mcp') to browse_screens
- Add parameters parameter for screen rendering
- Add screen rendering logic for non-root paths
- Return rendered content along with subscreens list
- Update list#Tools schema to expose new parameters

Default renderMode is 'mcp' unless explicitly specified.

Ean Schuessler committed 2025-12-23 13:04:14 -0600

Ean Schuessler committed 2025-12-23 11:43:12 -0600

- Replace redundant screen-specific tools with moqui_render_screen
- Simplify ToolsCall dispatcher and remove dead protocol mapping logic
- Improve GetScreenDetails to extract parameters from XML and entities
- Fix Basic auth and session handling in EnhancedMcpServlet
- Remove obsolete name decoding logic from McpUtils

Ean Schuessler committed 2025-12-19 19:29:50 -0600

Ean Schuessler committed 2025-12-19 17:04:54 -0600

Ean Schuessler committed 2025-12-19 16:57:18 -0600

…g, and recursive screen resolution

Ean Schuessler committed 2025-12-18 17:37:44 -0600

…ails), semantic naming, and McpUtils refactoring.

Ean Schuessler committed 2025-12-18 15:14:06 -0600

Ean Schuessler committed 2025-12-12 09:12:51 -0600

Ean Schuessler committed 2025-12-12 00:09:10 -0600

Ean Schuessler committed 2025-12-11 23:46:28 -0600

Ean Schuessler committed 2025-12-11 23:40:57 -0600

Ean Schuessler committed 2025-12-11 23:38:04 -0600