Skip to content

Ean Schuessler / mo-mcp

Go to a project
Toggle navigation
Toggle navigation pinning
f4e3d425 by Ean Schuessler
Options

Fix MCP error reporting and add dropdown metadata 

Error Handling:
- Check ec.message.hasError() before and after transaction flush
- Return "status": "error" with error messages instead of false success
- Prevents silent failures when constraint violations occur (e.g., invalid Party IDs)

Dropdown Metadata:
- Capture static dropdown options from sri.getFieldOptions()
- Capture dynamic-options config (transition, serverSearch, minLength, parameterMap)
- Enables model to understand searchable dropdowns vs static lists

This improves the model's ability to:
1. See clear error messages when operations fail
2. Understand dropdown behavior (server search vs static)
3. Take corrective action based on error feedback
1 parent d7412773
Inline Side-by-side
Showing 2 changed files with 113 additions and 1 deletions
......@@ -142,7 +142,26 @@
<#if fieldSubNode["text-line"]?has_content><#assign fieldMeta = fieldMeta + {"type": "text"}></#if>
<#if fieldSubNode["text-area"]?has_content><#assign fieldMeta = fieldMeta + {"type": "textarea"}></#if>
<#if fieldSubNode["drop-down"]?has_content><#assign fieldMeta = fieldMeta + {"type": "dropdown"}></#if>
<#if fieldSubNode["drop-down"]?has_content>
<#assign dropdownOptions = sri.getFieldOptions(.node)!>
<#if dropdownOptions?has_content>
<#assign fieldMeta = fieldMeta + {"type": "dropdown", "options": dropdownOptions?js_string!}>
<#else>
<#assign dynamicOptionNode = fieldSubNode["drop-down"]["dynamic-options"][0]!>
<#if dynamicOptionNode?has_content>
<#assign fieldMeta = fieldMeta + {"type": "dropdown", "dynamicOptions": {
"transition": (dynamicOptionNode["@transition"]!""),
"serverSearch": (dynamicOptionNode["@server-search"]! == "true"),
"minLength": (dynamicOptionNode["@min-length"]!"0"),
"parameterMap": (dynamicOptionNode["@parameter-map"]!"")?js_string!""
}}>
<#else>
<#assign fieldMeta = fieldMeta + {"type": "dropdown"}>
</#if>
</#if>
</#if>
</#if>
</#if>
<#if fieldSubNode["check"]?has_content><#assign fieldMeta = fieldMeta + {"type": "checkbox"}></#if>
<#if fieldSubNode["radio"]?has_content><#assign fieldMeta = fieldMeta + {"type": "radio"}></#if>
<#if fieldSubNode["date-find"]?has_content><#assign fieldMeta = fieldMeta + {"type": "date"}></#if>
......
......@@ -868,6 +868,80 @@ def wikiInstructions = getWikiInstructions(inputScreenPath)
renderParams.userId = ec.user.userId
renderParams.username = ec.user.username
// --- Execute Action if specified ---
def actionResult = [:]
if (action && resolvedScreenDef) {
ec.logger.info("MCP Screen Execution: Processing action '${action}' before rendering")
def transition = resolvedScreenDef.getAllTransitions().find { it.getName() == action }
if (transition) {
def serviceName = transition.getSingleServiceName()
if (serviceName) {
// Service action - execute service
ec.logger.info("MCP Screen Execution: Executing service action: ${serviceName}")
try {
def serviceParams = parameters ?: [:]
// Add standard context parameters
serviceParams.userId = ec.user.userId
serviceParams.username = ec.user.username
def svcResult = ec.service.sync().name(serviceName).parameters(serviceParams).call()
// Check for errors in execution context after service call
def hasError = ec.message.hasError()
// Flush transaction to ensure data is committed
ec.getTransaction().flush()
// Check again after flush - this catches constraint violations that occur during flush
hasError = hasError || ec.message.hasError()
if (hasError) {
actionResult = [
action: action,
status: "error",
message: ec.message.getErrorsString(),
result: null
]
ec.logger.error("MCP Screen Execution: Service ${serviceName} completed with errors: ${ec.message.getErrorsString()}")
} else {
actionResult = [
action: action,
status: "executed",
message: "Executed service ${serviceName}",
result: svcResult
]
ec.logger.info("MCP Screen Execution: Service ${serviceName} executed successfully")
}
ec.logger.info("MCP Screen Execution: Transaction flushed after action execution")
} catch (Exception e) {
actionResult = [
action: action,
status: "error",
message: "Error executing service ${serviceName}: ${e.message}"
]
ec.logger.error("MCP Screen Execution: Error executing service ${serviceName}", e)
throw e
}
} else {
// Screen transition - just navigate, no action result
actionResult = [
action: action,
status: "transition",
message: "Screen transition to ${action}"
]
ec.logger.info("MCP Screen Execution: Screen transition to ${action}")
}
} else {
ec.logger.warn("MCP Screen Execution: Action '${action}' not found in screen transitions")
}
}
// Clear entity cache before rendering to ensure fresh data
ec.cache.clearAllCaches()
ec.logger.info("MCP Screen Execution: Entity cache cleared before rendering")
def relativePath = testScreenPath
ec.logger.info("TESTRENDER root=${rootScreen} path=${relativePath} params=${renderParams}")
......@@ -1008,6 +1082,11 @@ def wikiInstructions = getWikiInstructions(inputScreenPath)
semanticState: semanticState
]
// Add action result if an action was executed
if (actionResult) {
mcpResult.actionResult = actionResult
}
// Truncate text preview only if terse=true
if (output) {
if (isTerse) {
......@@ -1598,12 +1677,26 @@ def wikiInstructions = getWikiInstructions(inputScreenPath)
if (serviceName) {
ec.logger.info("BrowseScreens: Executing service: ${serviceName}")
def serviceCallResult = ec.service.sync().name(serviceName).parameters(actionParams).call()
// Check for errors in execution context after service call
def hasError = ec.message.hasError()
if (hasError) {
actionResult = [
action: action,
status: "error",
message: ec.message.getErrorsString(),
result: null
]
ec.logger.error("BrowseScreens: Service ${serviceName} completed with errors: ${ec.message.getErrorsString()}")
} else {
actionResult = [
action: action,
status: "executed",
message: "Executed service ${serviceName}",
result: serviceCallResult
]
}
} else {
actionResult = [
action: action,
......