Fix compilation error by creating MCP-specific screen test infrastructure

- Created McpScreenTest and McpScreenTestRender interfaces
- Rewrote CustomScreenTestImpl to implement MCP-specific interfaces instead of extending framework's buggy ScreenTestImpl
- Added all required interface methods for complete functionality
- Resolves @Override annotation error on non-existent makeWebFacade method
- Maintains MCP functionality while providing independent screen test capabilities

@@ -13,19 +13,330 @@
  */
  */
 package org.moqui.mcp
 package org.moqui.mcp
 
 
-import org.moqui.impl.screen.ScreenTestImpl
+import groovy.transform.CompileStatic
 import org.moqui.impl.context.ExecutionContextFactoryImpl
 import org.moqui.impl.context.ExecutionContextFactoryImpl
+import org.moqui.impl.context.ExecutionContextImpl
+import org.moqui.context.WebFacade
+import org.moqui.util.ContextStack
+import org.moqui.impl.screen.ScreenUrlInfo
+import org.moqui.impl.screen.ScreenFacadeImpl
+import org.moqui.impl.screen.ScreenDefinition
+import org.moqui.screen.ScreenRender
+import org.moqui.BaseArtifactException
+import org.moqui.util.MNode
+import org.slf4j.Logger
+import org.slf4j.LoggerFactory
 
 
 /**
 /**
- * Custom ScreenTest implementation for MCP access
- * This provides the necessary web context for screen rendering in MCP environment
+ * MCP-specific ScreenTest implementation for simulating screen web requests
+ * This provides a proper web context for screen rendering in MCP environment
+ * using the MCP component's WebFacadeStub instead of the framework's buggy one
  */
  */
-class CustomScreenTestImpl extends ScreenTestImpl {
+@CompileStatic
+class CustomScreenTestImpl implements McpScreenTest {
     
     
+    protected final static Logger logger = LoggerFactory.getLogger(CustomScreenTestImpl.class)
+    
+    protected final ExecutionContextFactoryImpl ecfi
+    protected final ScreenFacadeImpl sfi
+    // see FtlTemplateRenderer.MoquiTemplateExceptionHandler, others
+    final List<String> errorStrings = ["[Template Error", "FTL stack trace", "Could not find subscreen or transition"]
+
+    protected String rootScreenLocation = null
+    protected ScreenDefinition rootScreenDef = null
+    protected String baseScreenPath = null
+    protected List<String> baseScreenPathList = null
+    protected ScreenDefinition baseScreenDef = null
+
+    protected String outputType = null
+    protected String characterEncoding = null
+    protected String macroTemplateLocation = null
+    protected String baseLinkUrl = null
+    protected String servletContextPath = null
+    protected String webappName = null
+    protected boolean skipJsonSerialize = false
+    protected static final String hostname = "localhost"
+
+    long renderCount = 0, errorCount = 0, totalChars = 0, startTime = System.currentTimeMillis()
+
+    final Map<String, Object> sessionAttributes = [:]
+
     CustomScreenTestImpl(ExecutionContextFactoryImpl ecfi) {
     CustomScreenTestImpl(ExecutionContextFactoryImpl ecfi) {
-        super(ecfi)
+        this.ecfi = ecfi
+        sfi = ecfi.screenFacade
+
+        // init default webapp, root screen
+        webappName('webroot')
+    }
+    
+    /**
+     * Create WebFacade using our properly implemented WebFacadeStub
+     * instead of the framework's version that has null contextPath issues
+     */
+    protected WebFacade createWebFacade(ExecutionContextFactoryImpl ecfi, Map<String, Object> parameters, 
+                                       Map<String, Object> sessionAttributes, String requestMethod) {
+        if (logger.isDebugEnabled()) {
+            logger.debug("CustomScreenTestImpl.createWebFacade() called with parameters: ${parameters?.keySet()}, sessionAttributes: ${sessionAttributes?.keySet()}, requestMethod: ${requestMethod}")
+        }
+        
+        // Use our MCP component's WebFacadeStub which properly handles null contextPath
+        return new org.moqui.mcp.WebFacadeStub(ecfi, parameters, sessionAttributes, requestMethod)
+    }
+
+    @Override
+    McpScreenTest rootScreen(String screenLocation) {
+        rootScreenLocation = screenLocation
+        rootScreenDef = sfi.getScreenDefinition(rootScreenLocation)
+        if (rootScreenDef == null) throw new IllegalArgumentException("Root screen not found: ${rootScreenLocation}")
+        baseScreenDef = rootScreenDef
+        return this
     }
     }
     
     
-    // Use the default makeWebFacade from ScreenTestImpl
-    // It should work for basic screen rendering in MCP context
+    @Override
+    McpScreenTest baseScreenPath(String screenPath) {
+        if (!rootScreenLocation) throw new BaseArtifactException("No rootScreen specified")
+        baseScreenPath = screenPath
+        if (baseScreenPath.endsWith("/")) baseScreenPath = baseScreenPath.substring(0, baseScreenPath.length() - 1)
+        if (baseScreenPath) {
+            baseScreenPathList = ScreenUrlInfo.parseSubScreenPath(rootScreenDef, rootScreenDef, [], baseScreenPath, null, sfi)
+            if (baseScreenPathList == null) throw new BaseArtifactException("Error in baseScreenPath, could find not base screen path ${baseScreenPath} under ${rootScreenDef.location}")
+            for (String screenName in baseScreenPathList) {
+                ScreenDefinition.SubscreensItem ssi = baseScreenDef.getSubscreensItem(screenName)
+                if (ssi == null) throw new BaseArtifactException("Error in baseScreenPath, could not find ${screenName} under ${baseScreenDef.location}")
+                baseScreenDef = sfi.getScreenDefinition(ssi.location)
+                if (baseScreenDef == null) throw new BaseArtifactException("Error in baseScreenPath, could not find screen ${screenName} at ${ssi.location}")
+            }
+        }
+        return this
+    }
+    
+    @Override McpScreenTest renderMode(String outputType) { this.outputType = outputType; return this }
+    @Override McpScreenTest encoding(String characterEncoding) { this.characterEncoding = characterEncoding; return this }
+    @Override McpScreenTest macroTemplate(String macroTemplateLocation) { this.macroTemplateLocation = macroTemplateLocation; return this }
+    @Override McpScreenTest baseLinkUrl(String baseLinkUrl) { this.baseLinkUrl = baseLinkUrl; return this }
+    @Override McpScreenTest servletContextPath(String scp) { this.servletContextPath = scp; return this }
+    @Override McpScreenTest skipJsonSerialize(boolean skip) { this.skipJsonSerialize = skip; return this }
+
+    @Override
+    McpScreenTest webappName(String wan) {
+        webappName = wan
+
+        // set a default root screen based on config for "localhost"
+        MNode webappNode = ecfi.getWebappNode(webappName)
+        for (MNode rootScreenNode in webappNode.children("root-screen")) {
+            if (hostname.matches(rootScreenNode.attribute('host'))) {
+                String rsLoc = rootScreenNode.attribute('location')
+                rootScreen(rsLoc)
+                break
+            }
+        }
+
+        return this
+    }
+
+    @Override
+    List<String> getNoRequiredParameterPaths(Set<String> screensToSkip) {
+        if (!rootScreenLocation) throw new IllegalStateException("No rootScreen specified")
+
+        List<String> noReqParmLocations = baseScreenDef.nestedNoReqParmLocations("", screensToSkip)
+        // logger.info("======= rootScreenLocation=${rootScreenLocation}\nbaseScreenPath=${baseScreenPath}\nbaseScreenDef: ${baseScreenDef.location}\nnoReqParmLocations: ${noReqParmLocations}")
+        return noReqParmLocations
+    }
+
+    @Override
+    void renderAll(List<String> screenPathList, Map<String, Object> parameters, String requestMethod) {
+        // NOTE: using single thread for now, doesn't actually make a lot of difference in overall test run time
+        int threads = 1
+        if (threads == 1) {
+            for (String screenPath in screenPathList) {
+                McpScreenTestRender str = render(screenPath, parameters, requestMethod)
+                logger.info("Rendered ${screenPath} in ${str.getRenderTime()}ms, ${str.getOutput()?.length()} characters")
+            }
+        } else {
+            ExecutionContextImpl eci = ecfi.getEci()
+            ArrayList<java.util.concurrent.Future> threadList = new ArrayList<java.util.concurrent.Future>(threads)
+            int screenPathListSize = screenPathList.size()
+            for (int si = 0; si < screenPathListSize; si++) {
+                String screenPath = (String) screenPathList.get(si)
+                threadList.add(eci.runAsync({
+                    McpScreenTestRender str = render(screenPath, parameters, requestMethod)
+                    logger.info("Rendered ${screenPath} in ${str.getRenderTime()}ms, ${str.getOutput()?.length()} characters")
+                }))
+                if (threadList.size() == threads || (si + 1) == screenPathList.size()) {
+                    for (int i = 0; i < threadList.size(); i++) { ((java.util.concurrent.Future) threadList.get(i)).get() }
+                    threadList.clear()
+                }
+            }
+        }
+    }
+
+    long getRenderCount() { return renderCount }
+    long getErrorCount() { return errorCount }
+    long getRenderTotalChars() { return totalChars }
+    long getStartTime() { return startTime }
+    
+    /**
+     * Override render method to use our custom ScreenTestRenderImpl
+     */
+    @Override
+    McpScreenTestRender render(String screenPath, Map<String, Object> parameters, String requestMethod) {
+        if (!rootScreenLocation) throw new IllegalArgumentException("No rootScreenLocation specified")
+        return new CustomScreenTestRenderImpl(this, screenPath, parameters, requestMethod).render()
+    }
+    
+    /**
+     * Custom ScreenTestRenderImpl that uses our WebFacadeStub
+     */
+    @CompileStatic
+    static class CustomScreenTestRenderImpl implements McpScreenTestRender {
+        protected final CustomScreenTestImpl sti
+        String screenPath = (String) null
+        Map<String, Object> parameters = [:]
+        String requestMethod = (String) null
+
+        ScreenRender screenRender = (ScreenRender) null
+        String outputString = (String) null
+        Object jsonObj = null
+        long renderTime = 0
+        Map postRenderContext = (Map) null
+        protected List<String> errorMessages = []
+
+        CustomScreenTestRenderImpl(CustomScreenTestImpl sti, String screenPath, Map<String, Object> parameters, String requestMethod) {
+            this.sti = sti
+            this.screenPath = screenPath
+            if (parameters != null) this.parameters.putAll(parameters)
+            this.requestMethod = requestMethod
+        }
+
+        McpScreenTestRender render() {
+            // render in separate thread with an independent ExecutionContext so it doesn't muck up the current one
+            ExecutionContextFactoryImpl ecfi = sti.ecfi
+            ExecutionContextImpl localEci = ecfi.getEci()
+            String username = localEci.userFacade.getUsername()
+            org.apache.shiro.subject.Subject loginSubject = localEci.userFacade.getCurrentSubject()
+            boolean authzDisabled = localEci.artifactExecutionFacade.getAuthzDisabled()
+            CustomScreenTestRenderImpl stri = this
+            Throwable threadThrown = null
+
+            Thread newThread = new Thread("CustomScreenTestRender") {
+                @Override void run() {
+                    try {
+                        ExecutionContextImpl threadEci = ecfi.getEci()
+                        if (loginSubject != null) threadEci.userFacade.internalLoginSubject(loginSubject)
+                        else if (username != null && !username.isEmpty()) threadEci.userFacade.internalLoginUser(username)
+                        if (authzDisabled) threadEci.artifactExecutionFacade.disableAuthz()
+                        // as this is used for server-side transition calls don't do tarpit checks
+                        threadEci.artifactExecutionFacade.disableTarpit()
+                        renderInternalCustom(threadEci, stri)
+                        threadEci.destroy()
+                    } catch (Throwable t) {
+                        threadThrown = t
+                    }
+                }
+            }
+            newThread.start()
+            newThread.join()
+            if (threadThrown != null) throw threadThrown
+            return this
+        }
+        
+        private static void renderInternalCustom(ExecutionContextImpl eci, CustomScreenTestRenderImpl stri) {
+            CustomScreenTestImpl csti = stri.sti
+            long startTime = System.currentTimeMillis()
+
+            // parse the screenPath
+            ArrayList<String> screenPathList = ScreenUrlInfo.parseSubScreenPath(csti.rootScreenDef, csti.baseScreenDef,
+                    csti.baseScreenPathList, stri.screenPath, stri.parameters, csti.sfi)
+            if (screenPathList == null) throw new BaseArtifactException("Could not find screen path ${stri.screenPath} under base screen ${csti.baseScreenDef.location}")
+
+            // push the context
+            ContextStack cs = eci.getContext()
+            cs.push()
+            // create the WebFacadeStub using our custom method
+            org.moqui.mcp.WebFacadeStub wfs = (org.moqui.mcp.WebFacadeStub) csti.createWebFacade(csti.ecfi, stri.parameters, csti.sessionAttributes, stri.requestMethod)
+            // set stub on eci, will also put parameters in the context
+            eci.setWebFacade(wfs)
+            // make the ScreenRender
+            ScreenRender screenRender = csti.sfi.makeRender()
+            stri.screenRender = screenRender
+            // pass through various settings
+            if (csti.rootScreenLocation != null && csti.rootScreenLocation.length() > 0) screenRender.rootScreen(csti.rootScreenLocation)
+            if (csti.outputType != null && csti.outputType.length() > 0) screenRender.renderMode(csti.outputType)
+            if (csti.characterEncoding != null && csti.characterEncoding.length() > 0) screenRender.encoding(csti.characterEncoding)
+            if (csti.macroTemplateLocation != null && csti.macroTemplateLocation.length() > 0) screenRender.macroTemplate(csti.macroTemplateLocation)
+            if (csti.baseLinkUrl != null && csti.baseLinkUrl.length() > 0) screenRender.baseLinkUrl(csti.baseLinkUrl)
+            if (csti.servletContextPath != null && csti.servletContextPath.length() > 0) screenRender.servletContextPath(csti.servletContextPath)
+            screenRender.webappName(csti.webappName)
+            if (csti.skipJsonSerialize) {
+                // Set skipJsonSerialize on our WebFacadeStub
+                wfs.skipJsonSerialize = true
+            }
+
+            // set the screenPath
+            screenRender.screenPath(screenPathList)
+
+            // do the render
+            try {
+                screenRender.render(wfs.getRequest(), wfs.getResponse())
+                // get the response text from the WebFacadeStub
+                stri.outputString = wfs.getResponseText()
+                stri.jsonObj = wfs.getResponseJsonObj()
+            } catch (Throwable t) {
+                String errMsg = "Exception in render of ${stri.screenPath}: ${t.toString()}"
+                logger.warn(errMsg, t)
+                stri.errorMessages.add(errMsg)
+                csti.errorCount++
+            }
+            // calc renderTime
+            stri.renderTime = System.currentTimeMillis() - startTime
+
+            // pop the context stack, get rid of var space
+            stri.postRenderContext = cs.pop()
+
+            // check, pass through, error messages
+            if (eci.message.hasError()) {
+                stri.errorMessages.addAll(eci.message.getErrors())
+                eci.message.clearErrors()
+                StringBuilder sb = new StringBuilder("Error messages from ${stri.screenPath}: ")
+                for (String errorMessage in stri.errorMessages) sb.append("\n").append(errorMessage)
+                logger.warn(sb.toString())
+                csti.errorCount += stri.errorMessages.size()
+            }
+
+            // check for error strings in output
+            if (stri.outputString != null) for (String errorStr in csti.errorStrings) if (stri.outputString.contains(errorStr)) {
+                String errMsg = "Found error [${errorStr}] in output from ${stri.screenPath}"
+                stri.errorMessages.add(errMsg)
+                csti.errorCount++
+                logger.warn(errMsg)
+            }
+
+            // update stats
+            csti.renderCount++
+            if (stri.outputString != null) csti.totalChars += stri.outputString.length()
+        }
+
+        @Override ScreenRender getScreenRender() { return screenRender }
+        @Override String getOutput() { return outputString }
+        @Override Object getJsonObject() { return jsonObj }
+        @Override long getRenderTime() { return renderTime }
+        @Override Map getPostRenderContext() { return postRenderContext }
+        @Override List<String> getErrorMessages() { return errorMessages }
+
+        @Override
+        boolean assertContains(String text) {
+            if (!outputString) return false
+            return outputString.contains(text)
+        }
+        @Override
+        boolean assertNotContains(String text) {
+            if (!outputString) return true
+            return !outputString.contains(text)
+        }
+        @Override
+        boolean assertRegex(String regex) {
+            if (!outputString) return false
+            return outputString.matches(regex)
+        }
+    }
 }
 }
\ No newline at end of file

+/*
+ * This software is in the public domain under CC0 1.0 Universal plus a 
+ * Grant of Patent License.
+ * 
+ * To the extent possible under law, author(s) have dedicated all
+ * copyright and related and neighboring rights to this software to the
+ * public domain worldwide. This software is distributed without any
+ * warranty.
+ * 
+ * You should have received a copy of the CC0 Public Domain Dedication
+ * along with this software (see the LICENSE.md file). If not, see
+ * <http://creativecommons.org/publicdomain/zero/1.0/>.
+ */
+package org.moqui.mcp
+
+import groovy.transform.CompileStatic
+
+/**
+ * MCP-specific ScreenTest interface for simulating screen web requests
+ * This is separate from the core Moqui ScreenTest system and tailored for MCP needs
+ */
+@CompileStatic
+interface McpScreenTest {
+    McpScreenTest rootScreen(String screenLocation)
+    McpScreenTest baseScreenPath(String screenPath)
+    McpScreenTest renderMode(String outputType)
+    McpScreenTest encoding(String characterEncoding)
+    McpScreenTest macroTemplate(String macroTemplateLocation)
+    McpScreenTest baseLinkUrl(String baseLinkUrl)
+    McpScreenTest servletContextPath(String scp)
+    McpScreenTest skipJsonSerialize(boolean skip)
+    McpScreenTest webappName(String wan)
+    
+    McpScreenTestRender render(String screenPath, Map<String, Object> parameters, String requestMethod)
+    void renderAll(List<String> screenPathList, Map<String, Object> parameters, String requestMethod)
+    
+    List<String> getNoRequiredParameterPaths(Set<String> screensToSkip)
+    
+    long getRenderCount()
+    long getErrorCount()
+    long getRenderTotalChars()
+    long getStartTime()
+}
\ No newline at end of file

+/*
+ * This software is in the public domain under CC0 1.0 Universal plus a 
+ * Grant of Patent License.
+ * 
+ * To the extent possible under law, author(s) have dedicated all
+ * copyright and related and neighboring rights to this software to the
+ * public domain worldwide. This software is distributed without any
+ * warranty.
+ * 
+ * You should have received a copy of the CC0 Public Domain Dedication
+ * along with this software (see the LICENSE.md file). If not, see
+ * <http://creativecommons.org/publicdomain/zero/1.0/>.
+ */
+package org.moqui.mcp
+
+import groovy.transform.CompileStatic
+import org.moqui.screen.ScreenRender
+
+/**
+ * MCP-specific ScreenTestRender interface for screen rendering results
+ * This is separate from the core Moqui ScreenTest system and tailored for MCP needs
+ */
+@CompileStatic
+interface McpScreenTestRender {
+    ScreenRender getScreenRender()
+    String getOutput()
+    Object getJsonObject()
+    long getRenderTime()
+    Map getPostRenderContext()
+    List<String> getErrorMessages()
+    
+    boolean assertContains(String text)
+    boolean assertNotContains(String text)
+    boolean assertRegex(String regex)
+}
\ No newline at end of file