Capture NIT so we generate less warnings

When a NIT was present, we would warn about unrecognized PIDs every time it was encountered. Capture the PID value so we can silently ignore it. Add a test case for NIT parsing.

@@ -221,9 +221,9 @@
         patTableId, // :int
         patCurrentNextIndicator, // Boolean
         patSectionLength, // :uint
-        patNumEntries, // :uint
-        patNumPrograms, // :uint
-        patProgramOffset, // :uint
+        programNumber, // :uint
+        programPid, // :uint
+        patEntriesEnd, // :uint
 
         pesPacketSize, // :int,
         dataAlignmentIndicator, // :Boolean,
@@ -296,6 +296,8 @@
         if (patCurrentNextIndicator) {
           // section_length specifies the number of bytes following
           // its position to the end of this section
+          // section_length = rest of header + (n * entry length) + CRC
+          // = 5 + (n * 4) + 4
           patSectionLength =  (data[offset + 1] & 0x0F) << 8 | data[offset + 2];
           // move past the rest of the PSI header to the first program
           // map table entry
@@ -303,28 +305,22 @@
 
           // we don't handle streams with more than one program, so
           // raise an exception if we encounter one
-          // section_length = rest of header + (n * entry length) + CRC
-          // = 5 + (n * 4) + 4
-          patNumEntries = (patSectionLength - 5 - 4) / 4;
-          patNumPrograms = 0;
-          patProgramOffset = offset;
-          for (var entryIndex = 0; entryIndex < patNumEntries; entryIndex++) {
-            // network PID program number equals 0 and can be ignored
-            if (((data[offset + 4*entryIndex]) << 8 | data[offset + 4*entryIndex + 1]) > 0) {
-                patNumPrograms++;
-                patProgramOffset = offset + 4*entryIndex;
-            }
-          }
-          if (patNumPrograms !== 1) {
+          patEntriesEnd = offset + (patSectionLength - 5 - 4);
+          for (; offset < patEntriesEnd; offset += 4) {
+            programNumber = (data[offset] << 8 | data[offset + 1]);
+            programPid = (data[offset + 2] & 0x1F) << 8 | data[offset + 3];
+            // network PID program number equals 0
+            // this is primarily an artifact of EBU DVB and can be ignored
+            if (programNumber === 0) {
+              self.stream.networkPid = programPid;
+            } else if (self.stream.pmtPid === undefined) {
+              // the Program Map Table (PMT) associates the underlying
+              // video and audio streams with a unique PID
+              self.stream.pmtPid = programPid;
+            } else if (self.stream.pmtPid !== programPid) {
               throw new Error("TS has more that 1 program");
             }
-          else {
-            offset = patProgramOffset;
           }
-
-          // the Program Map Table (PMT) associates the underlying
-          // video and audio streams with a unique PID
-          self.stream.pmtPid = (data[offset + 2] & 0x1F) << 8 | data[offset + 3];
         }
       } else if (pid === self.stream.programMapTable[STREAM_TYPES.h264] ||
                  pid === self.stream.programMapTable[STREAM_TYPES.adts] ||
@@ -477,6 +473,8 @@
           }
         }
         // We could test the CRC here to detect corruption with extra CPU cost
+      } else if (self.stream.networkPid === pid) {
+        // network information specific data (NIT) packet
       } else if (0x0011 === pid) {
         // Service Description Table
       } else if (0x1FFF === pid) {

@@ -121,13 +121,26 @@
   makePat = function(options) {
     var
       result = [],
+      programEntries = [],
+      sectionLength,
       k;
 
+    // build the program entries first
+    for (k in options.programs) {
+      // program_number
+      programEntries.push((k & 0xFF00) >>> 8);
+      programEntries.push(k & 0x00FF);
+      // reserved program_map_pid
+      programEntries.push((options.programs[k] & 0x1f00) >>> 8);
+      programEntries.push(options.programs[k] & 0xff);
+    }
+    sectionLength = programEntries.length + 5 + 4;
+
     // table_id
     result.push(0x00);
     // section_syntax_indicator '0' reserved section_length
-    result.push(0x80);
-    result.push(0x0d); // section_length for one program
+    result.push(0x80 | ((0x300 & sectionLength) >>> 8));
+    result.push(0xff & sectionLength); // section_length
     // transport_stream_id
     result.push(0x00);
     result.push(0x00);
@@ -137,14 +150,8 @@
     result.push(0x00);
     // last_section_number
     result.push(0x00);
-    for (k in options.programs) {
-      // program_number
-      result.push((k & 0xFF00) >>> 8);
-      result.push(k & 0x00FF);
-      // reserved program_map_pid
-      result.push((options.programs[k] & 0x1f00) >>> 8);
-      result.push(options.programs[k] & 0xff);
-    }
+    // program entries
+    result = result.concat(programEntries);
     return result;
   };
 
@@ -211,6 +218,17 @@
     strictEqual(parser.stream.programMapTable[adtsType], 0x03, 'audio is PID 3');
   });
 
+  test('ignores network information specific data (NIT) in the PAT', function() {
+    parser.parseSegmentBinaryData(new Uint8Array(makePacket({
+      programs: {
+        0x01: [0x01],
+        0x00: [0x00] // a NIT has a reserved PID of 0x00
+      }
+    })));
+
+    ok(true, 'did not throw when a NIT is encountered');
+  });
+
   test('recognizes metadata streams', function() {
     parser.parseSegmentBinaryData(new Uint8Array(makePacket({
       programs: {