code review comments
Showing
1 changed file
with
5 additions
and
5 deletions
... | @@ -32,7 +32,7 @@ videojs.hls = { | ... | @@ -32,7 +32,7 @@ videojs.hls = { |
32 | 32 | ||
33 | var | 33 | var |
34 | 34 | ||
35 | pluginOptions, | 35 | settings, |
36 | 36 | ||
37 | // the desired length of video to maintain in the buffer, in seconds | 37 | // the desired length of video to maintain in the buffer, in seconds |
38 | goalBufferLength = 5, | 38 | goalBufferLength = 5, |
... | @@ -129,7 +129,7 @@ var | ... | @@ -129,7 +129,7 @@ var |
129 | if (responseType) { | 129 | if (responseType) { |
130 | request.responseType = responseType; | 130 | request.responseType = responseType; |
131 | } | 131 | } |
132 | if (pluginOptions.withCredentials) { | 132 | if (settings.withCredentials) { |
133 | request.withCredentials = true; | 133 | request.withCredentials = true; |
134 | } | 134 | } |
135 | 135 | ||
... | @@ -318,7 +318,7 @@ var | ... | @@ -318,7 +318,7 @@ var |
318 | return; | 318 | return; |
319 | } | 319 | } |
320 | 320 | ||
321 | pluginOptions = options || {}; | 321 | settings = videojs.util.mergeOptions({}, options); |
322 | 322 | ||
323 | srcUrl = (function() { | 323 | srcUrl = (function() { |
324 | var | 324 | var |
... | @@ -658,7 +658,8 @@ var | ... | @@ -658,7 +658,8 @@ var |
658 | // try moving on to the next segment | 658 | // try moving on to the next segment |
659 | player.hls.mediaIndex++; | 659 | player.hls.mediaIndex++; |
660 | return; | 660 | return; |
661 | } else { | 661 | } |
662 | |||
662 | // stop processing if the request was aborted | 663 | // stop processing if the request was aborted |
663 | if (!this.response) { | 664 | if (!this.response) { |
664 | return; | 665 | return; |
... | @@ -693,7 +694,6 @@ var | ... | @@ -693,7 +694,6 @@ var |
693 | // figure out what stream the next segment should be downloaded from | 694 | // figure out what stream the next segment should be downloaded from |
694 | // with the updated bandwidth information | 695 | // with the updated bandwidth information |
695 | updateCurrentPlaylist(); | 696 | updateCurrentPlaylist(); |
696 | } | ||
697 | }); | 697 | }); |
698 | }; | 698 | }; |
699 | 699 | ... | ... |
-
Please register or sign in to post a comment