bf3cf7b6 by Gary Katsevman

code review comments

1 parent b2f8fdc9
......@@ -32,7 +32,7 @@ videojs.hls = {
var
pluginOptions,
settings,
// the desired length of video to maintain in the buffer, in seconds
goalBufferLength = 5,
......@@ -129,7 +129,7 @@ var
if (responseType) {
request.responseType = responseType;
}
if (pluginOptions.withCredentials) {
if (settings.withCredentials) {
request.withCredentials = true;
}
......@@ -318,7 +318,7 @@ var
return;
}
pluginOptions = options || {};
settings = videojs.util.mergeOptions({}, options);
srcUrl = (function() {
var
......@@ -658,7 +658,8 @@ var
// try moving on to the next segment
player.hls.mediaIndex++;
return;
} else {
}
// stop processing if the request was aborted
if (!this.response) {
return;
......@@ -693,7 +694,6 @@ var
// figure out what stream the next segment should be downloaded from
// with the updated bandwidth information
updateCurrentPlaylist();
}
});
};
......