Don't append data until the previous update finishes

If segments are delivered very quickly, it's possible that a segment after a discontinuity will be ready before the previous segment is finished getting processed by the media source. Our current mechanism for signalling discontinuities is synchronous so this could lead to us injecting a discontinuity into the middle of the first segment instead of at the end. Instead, adopt a workflow more closely aligned to how real SourceBuffers work and don't append additional bytes until the previous append has been fully processed.

@@ -721,10 +721,18 @@ videojs.Hls.prototype.drainBuffer = function(event) {
     segmentOffset = 0,
     segmentOffset = 0,
     segmentBuffer = this.segmentBuffer_;
     segmentBuffer = this.segmentBuffer_;
 
 
+  // if the buffer is empty or the source buffer hasn't been created
+  // yet, do nothing
   if (!segmentBuffer.length || !this.sourceBuffer) {
   if (!segmentBuffer.length || !this.sourceBuffer) {
     return;
     return;
   }
   }
 
 
+  // we can't append more data if the source buffer is busy processing
+  // what we've already sent
+  if (this.sourceBuffer.updating) {
+    return;
+  }
+
   segmentInfo = segmentBuffer[0];
   segmentInfo = segmentBuffer[0];
 
 
   mediaIndex = segmentInfo.mediaIndex;
   mediaIndex = segmentInfo.mediaIndex;
@@ -825,13 +833,18 @@ videojs.Hls.prototype.drainBuffer = function(event) {
     this.el().vjs_discontinuity();
     this.el().vjs_discontinuity();
   }
   }
 
 
+  (function() {
+    var segmentByteLength = 0, j, segment;
     for (i = 0; i < tags.length; i++) {
     for (i = 0; i < tags.length; i++) {
-    // queue up the bytes to be appended to the SourceBuffer
-    // the queue gives control back to the browser between tags
-    // so that large segments don't cause a "hiccup" in playback
-
-    this.sourceBuffer.appendBuffer(tags[i].bytes, this.player());
+      segmentByteLength += tags[i].bytes.byteLength;
+    }
+    segment = new Uint8Array(segmentByteLength);
+    for (i = 0, j = 0; i < tags.length; i++) {
+      segment.set(tags[i].bytes, j);
+      j += tags[i].bytes.byteLength;
     }
     }
+    this.sourceBuffer.appendBuffer(segment);
+  }).call(this);
 
 
   // we're done processing this segment
   // we're done processing this segment
   segmentBuffer.shift();
   segmentBuffer.shift();

@@ -953,6 +953,29 @@ test('only makes one segment request at a time', function() {
   strictEqual(1, requests.length, 'only one XHR is made');
   strictEqual(1, requests.length, 'only one XHR is made');
 });
 });
 
 
+test('only appends one segment at a time', function() {
+  var appends = 0, tags = [{ pts: 0, bytes: new Uint8Array(1) }];
+  videojs.Hls.SegmentParser = mockSegmentParser(tags);
+  player.src({
+    src: 'manifest/media.m3u8',
+    type: 'application/vnd.apple.mpegurl'
+  });
+  openMediaSource(player);
+  standardXHRResponse(requests.pop()); // media.m3u8
+  standardXHRResponse(requests.pop()); // segment 0
+
+  player.hls.sourceBuffer.updating = true;
+  player.hls.sourceBuffer.appendBuffer = function() {
+    appends++;
+  };
+  tags.push({ pts: 0, bytes: new Uint8Array(1) });
+
+  player.hls.checkBuffer_();
+  standardXHRResponse(requests.pop()); // segment 1
+  player.hls.checkBuffer_(); // should be a no-op
+  equal(appends, 0, 'did not append while updating');
+});
+
 test('cancels outstanding XHRs when seeking', function() {
 test('cancels outstanding XHRs when seeking', function() {
   player.src({
   player.src({
     src: 'manifest/media.m3u8',
     src: 'manifest/media.m3u8',
@@ -1064,21 +1087,8 @@ test('flushes the parser after each segment', function() {
 });
 });
 
 
 test('calculates preciseTimestamp and preciseDuration for a new segment', function() {
 test('calculates preciseTimestamp and preciseDuration for a new segment', function() {
-  // mock out the segment parser
-  videojs.Hls.SegmentParser = function() {
-    var tagsAvailable = true,
-        tag = { pts : 200000 };
-    this.getFlvHeader = function() {
-      return [];
-    };
-    this.parseSegmentBinaryData = function() {};
-    this.flushTags = function() {};
-    this.tagsAvailable = function() { return tagsAvailable; };
-    this.getNextTag = function() { tagsAvailable = false; return tag; };
-    this.metadataStream = {
-      on: Function.prototype
-    };
-  };
+  var tags = [{ pts : 200000, bytes: new Uint8Array(1) }];
+  videojs.Hls.SegmentParser = mockSegmentParser(tags);
 
 
   player.src({
   player.src({
     src: 'manifest/media.m3u8',
     src: 'manifest/media.m3u8',
@@ -1168,7 +1178,7 @@ test('drops tags before the target timestamp when seeking', function() {
   };
   };
 
 
   // push a tag into the buffer
   // push a tag into the buffer
-  tags.push({ pts: 0, bytes: 0 });
+  tags.push({ pts: 0, bytes: new Uint8Array(1) });
 
 
   player.src({
   player.src({
     src: 'manifest/media.m3u8',
     src: 'manifest/media.m3u8',
@@ -1183,20 +1193,20 @@ test('drops tags before the target timestamp when seeking', function() {
   while (i--) {
   while (i--) {
     tags.unshift({
     tags.unshift({
       pts: i * 1000,
       pts: i * 1000,
-      bytes: i
+      bytes: new Uint8Array([i])
     });
     });
   }
   }
   player.currentTime(7);
   player.currentTime(7);
   standardXHRResponse(requests[2]);
   standardXHRResponse(requests[2]);
 
 
-  deepEqual(bytes, [7,8,9], 'three tags are appended');
+  deepEqual(bytes, [new Uint8Array([7,8,9])], 'three tags are appended');
 });
 });
 
 
 test('calls abort() on the SourceBuffer before seeking', function() {
 test('calls abort() on the SourceBuffer before seeking', function() {
   var
   var
     aborts = 0,
     aborts = 0,
     bytes = [],
     bytes = [],
-    tags = [{ pts: 0, bytes: 0 }];
+    tags = [{ pts: 0, bytes: new Uint8Array(1) }];
 
 
 
 
   // track calls to abort()
   // track calls to abort()
@@ -1221,8 +1231,8 @@ test('calls abort() on the SourceBuffer before seeking', function() {
 
 
   // drainBuffer() uses the first PTS value to account for any timestamp discontinuities in the stream
   // drainBuffer() uses the first PTS value to account for any timestamp discontinuities in the stream
   // adding a tag with a PTS of zero looks like a stream with no discontinuities
   // adding a tag with a PTS of zero looks like a stream with no discontinuities
-  tags.push({ pts: 0, bytes: 0 });
-  tags.push({ pts: 7000, bytes: 7 });
+  tags.push({ pts: 0, bytes: new Uint8Array(1) });
+  tags.push({ pts: 7000, bytes: new Uint8Array([7]) });
   // seek to 7s
   // seek to 7s
   player.currentTime(7);
   player.currentTime(7);
   standardXHRResponse(requests[2]);
   standardXHRResponse(requests[2]);
@@ -1474,7 +1484,7 @@ test('calls vjs_discontinuity() before appending bytes at a discontinuity', func
   player.hls.checkBuffer_();
   player.hls.checkBuffer_();
   strictEqual(discontinuities, 0, 'no discontinuities before the segment is received');
   strictEqual(discontinuities, 0, 'no discontinuities before the segment is received');
 
 
-  tags.push({});
+  tags.push({ pts: 0, bytes: new Uint8Array(1) });
   standardXHRResponse(requests.pop());
   standardXHRResponse(requests.pop());
   strictEqual(discontinuities, 1, 'signals a discontinuity');
   strictEqual(discontinuities, 1, 'signals a discontinuity');
 });
 });
@@ -1521,7 +1531,7 @@ test('clears the segment buffer on seek', function() {
 
 
   // seek back to the beginning
   // seek back to the beginning
   player.currentTime(0);
   player.currentTime(0);
-  tags.push({ pts: 0, bytes: 0 });
+  tags.push({ pts: 0, bytes: new Uint8Array(1) });
   standardXHRResponse(requests.pop());
   standardXHRResponse(requests.pop());
   strictEqual(aborts, 1, 'aborted once for the seek');
   strictEqual(aborts, 1, 'aborted once for the seek');
 
 
@@ -1571,7 +1581,7 @@ test('continues playing after seek to discontinuity', function() {
 
 
   // seek to the discontinuity
   // seek to the discontinuity
   player.currentTime(10);
   player.currentTime(10);
-  tags.push({ pts: 0, bytes: 0 });
+  tags.push({ pts: 0, bytes: new Uint8Array(1) });
   standardXHRResponse(requests.pop());
   standardXHRResponse(requests.pop());
   strictEqual(aborts, 1, 'aborted once for the seek');
   strictEqual(aborts, 1, 'aborted once for the seek');
 
 
@@ -1853,8 +1863,8 @@ test('drainBuffer will not proceed with empty source buffer', function() {
   };
   };
 
 
   player.hls.sourceBuffer = undefined;
   player.hls.sourceBuffer = undefined;
-  compareBuffer = [{mediaIndex: 0, playlist: newMedia, offset: 0, bytes: [0,0,0]}];
-  player.hls.segmentBuffer_ = [{mediaIndex: 0, playlist: newMedia, offset: 0, bytes: [0,0,0]}];
+  compareBuffer = [{mediaIndex: 0, playlist: newMedia, offset: 0, bytes: new Uint8Array(3)}];
+  player.hls.segmentBuffer_ = [{mediaIndex: 0, playlist: newMedia, offset: 0, bytes: new Uint8Array(3)}];
 
 
   player.hls.drainBuffer();
   player.hls.drainBuffer();
 
 
@@ -2018,7 +2028,7 @@ test('retries key requests once upon failure', function() {
 
 
 test('skip segments if key requests fail more than once', function() {
 test('skip segments if key requests fail more than once', function() {
   var bytes = [],
   var bytes = [],
-      tags = [{ pts: 0, bytes: 0 }];
+      tags = [{ pts: 0, bytes: new Uint8Array(1) }];
 
 
   videojs.Hls.SegmentParser = mockSegmentParser(tags);
   videojs.Hls.SegmentParser = mockSegmentParser(tags);
   window.videojs.SourceBuffer = function() {
   window.videojs.SourceBuffer = function() {
@@ -2047,7 +2057,7 @@ test('skip segments if key requests fail more than once', function() {
   requests.shift().respond(404); // fail key, again
   requests.shift().respond(404); // fail key, again
 
 
   tags.length = 0;
   tags.length = 0;
-  tags.push({pts: 0, bytes: 1});
+  tags.push({pts: 0, bytes: new Uint8Array([1]) });
   player.hls.checkBuffer_();
   player.hls.checkBuffer_();
   standardXHRResponse(requests.shift()); // segment 2
   standardXHRResponse(requests.shift()); // segment 2
   equal(bytes.length, 1, 'bytes from the ts segments should not be added');
   equal(bytes.length, 1, 'bytes from the ts segments should not be added');
@@ -2060,7 +2070,7 @@ test('skip segments if key requests fail more than once', function() {
   player.hls.checkBuffer_();
   player.hls.checkBuffer_();
 
 
   equal(bytes.length, 2, 'bytes from the second ts segment should be added');
   equal(bytes.length, 2, 'bytes from the second ts segment should be added');
-  equal(bytes[1], 1, 'the bytes from the second segment are added and not the first');
+  deepEqual(bytes[1], new Uint8Array([1]), 'the bytes from the second segment are added and not the first');
 });
 });
 
 
 test('the key is supplied to the decrypter in the correct format', function() {
 test('the key is supplied to the decrypter in the correct format', function() {
@@ -2191,7 +2201,7 @@ test('resolves relative key URLs against the playlist', function() {
 });
 });
 
 
 test('treats invalid keys as a key request failure', function() {
 test('treats invalid keys as a key request failure', function() {
-  var tags = [{ pts: 0, bytes: 0 }], bytes = [];
+  var tags = [{ pts: 0, bytes: new Uint8Array(1) }], bytes = [];
   videojs.Hls.SegmentParser = mockSegmentParser(tags);
   videojs.Hls.SegmentParser = mockSegmentParser(tags);
   window.videojs.SourceBuffer = function() {
   window.videojs.SourceBuffer = function() {
     this.appendBuffer = function(chunk) {
     this.appendBuffer = function(chunk) {
@@ -2231,12 +2241,12 @@ test('treats invalid keys as a key request failure', function() {
   equal(bytes[0], 'flv', 'appended the flv header');
   equal(bytes[0], 'flv', 'appended the flv header');
 
 
   tags.length = 0;
   tags.length = 0;
-  tags.push({ pts: 1, bytes: 1 });
+  tags.push({ pts: 1, bytes: new Uint8Array([1]) });
   // second segment request
   // second segment request
   standardXHRResponse(requests.shift());
   standardXHRResponse(requests.shift());
 
 
   equal(bytes.length, 2, 'appended bytes');
   equal(bytes.length, 2, 'appended bytes');
-  equal(1, bytes[1], 'skipped to the second segment');
+  deepEqual(new Uint8Array([1]), bytes[1], 'skipped to the second segment');
 });
 });
 
 
 test('live stream should not call endOfStream', function(){
 test('live stream should not call endOfStream', function(){