Grow the internal array if an FLV tag needs more than 16k

Before each write, check that the FLV tag's buffer has enough capacity and grow it if necessary.

@@ -7,7 +7,25 @@ hls.FlvTag = function(type, extraData) {
   var
   var
     // Counter if this is a metadata tag, nal start marker if this is a video
     // Counter if this is a metadata tag, nal start marker if this is a video
     // tag. unused if this is an audio tag
     // tag. unused if this is an audio tag
-    adHoc = 0; // :uint
+    adHoc = 0, // :uint
+
+    // checks whether the FLV tag has enough capacity to accept the proposed
+    // write and re-allocates the internal buffers if necessary
+    prepareWrite = function(flv, count) {
+      var
+        bytes,
+        minLength = flv.position + count;
+      if (minLength < flv.bytes.byteLength) {
+        // there's enough capacity so do nothing
+        return;
+      }
+
+      // allocate a new buffer and copy over the data that will not be modified
+      bytes = new Uint8Array(minLength * 2);
+      bytes.set(flv.bytes.subarray(0, flv.position), 0);
+      flv.bytes = bytes;
+      flv.view = new DataView(flv.bytes.buffer);
+    };
 
 
   this.keyFrame = false; // :Boolean
   this.keyFrame = false; // :Boolean
 
 
@@ -27,7 +45,6 @@ hls.FlvTag = function(type, extraData) {
     throw("Error Unknown TagType");
     throw("Error Unknown TagType");
   }
   }
 
 
-  // XXX: I have no idea if 16k is enough to buffer arbitrary FLV tags
   this.bytes = new Uint8Array(16384);
   this.bytes = new Uint8Array(16384);
   this.view = new DataView(this.bytes.buffer);
   this.view = new DataView(this.bytes.buffer);
   this.bytes[0] = type;
   this.bytes[0] = type;
@@ -41,20 +58,22 @@ hls.FlvTag = function(type, extraData) {
 
 
   // ByteArray#writeBytes(bytes:ByteArray, offset:uint = 0, length:uint = 0)
   // ByteArray#writeBytes(bytes:ByteArray, offset:uint = 0, length:uint = 0)
   this.writeBytes = function(bytes, offset, length) {
   this.writeBytes = function(bytes, offset, length) {
-    offset = offset || 0;
+    var
+      start = offset || 0,
+      end;
     length = length || bytes.byteLength;
     length = length || bytes.byteLength;
+    end = start + length;
+
+    prepareWrite(this, length);
+    this.bytes.set(bytes.subarray(start, end), this.position);
 
 
-    try {
-      this.bytes.set(bytes.subarray(offset, offset + length), this.position);
-    } catch(e) {
-      throw e;
-    }
     this.position += length;
     this.position += length;
     this.length = Math.max(this.length, this.position);
     this.length = Math.max(this.length, this.position);
   };
   };
 
 
   // ByteArray#writeByte(value:int):void
   // ByteArray#writeByte(value:int):void
   this.writeByte = function(byte) {
   this.writeByte = function(byte) {
+    prepareWrite(this, 1);
     this.bytes[this.position] = byte;
     this.bytes[this.position] = byte;
     this.position++;
     this.position++;
     this.length = Math.max(this.length, this.position);
     this.length = Math.max(this.length, this.position);
@@ -62,6 +81,7 @@ hls.FlvTag = function(type, extraData) {
 
 
   // ByteArray#writeShort(value:int):void
   // ByteArray#writeShort(value:int):void
   this.writeShort = function(short) {
   this.writeShort = function(short) {
+    prepareWrite(this, 2);
     this.view.setUint16(this.position, short);
     this.view.setUint16(this.position, short);
     this.position += 2;
     this.position += 2;
     this.length = Math.max(this.length, this.position);
     this.length = Math.max(this.length, this.position);
@@ -126,13 +146,16 @@ hls.FlvTag = function(type, extraData) {
   // (key:String, val:Number):void
   // (key:String, val:Number):void
   this.writeMetaDataDouble = function(key, val) {
   this.writeMetaDataDouble = function(key, val) {
     var i;
     var i;
+    prepareWrite(this, 2);
     this.view.setUint16(this.position, key.length);
     this.view.setUint16(this.position, key.length);
     this.position += 2;
     this.position += 2;
     for (i in key) {
     for (i in key) {
       console.assert(key.charCodeAt(i) < 255);
       console.assert(key.charCodeAt(i) < 255);
+      prepareWrite(this, 1);
       this.bytes[this.position] = key.charCodeAt(i);
       this.bytes[this.position] = key.charCodeAt(i);
       this.position++; 
       this.position++; 
     }
     }
+    prepareWrite(this, 9);
     this.view.setUint8(this.position, 0x00);
     this.view.setUint8(this.position, 0x00);
     this.position++;
     this.position++;
     this.view.setFloat64(this.position, val);
     this.view.setFloat64(this.position, val);
@@ -144,13 +167,16 @@ hls.FlvTag = function(type, extraData) {
   // (key:String, val:Boolean):void
   // (key:String, val:Boolean):void
   this.writeMetaDataBoolean = function(key, val) {
   this.writeMetaDataBoolean = function(key, val) {
     var i;
     var i;
+    prepareWrite(this, 2);
     this.view.setUint16(this.position, key.length);
     this.view.setUint16(this.position, key.length);
     this.position += 2;
     this.position += 2;
     for (i in key) {
     for (i in key) {
       console.assert(key.charCodeAt(i) < 255);
       console.assert(key.charCodeAt(i) < 255);
+      prepareWrite(this, 1);
       this.bytes[this.position] = key.charCodeAt(i);
       this.bytes[this.position] = key.charCodeAt(i);
       this.position++;
       this.position++;
     }
     }
+    prepareWrite(this, 2);
     this.view.setUint8(this.position, 0x01);
     this.view.setUint8(this.position, 0x01);
     this.position++;
     this.position++;
     this.view.setUint8(this.position, val ? 0x01 : 0x00);
     this.view.setUint8(this.position, val ? 0x01 : 0x00);

@@ -44,4 +44,17 @@ test('writeShort writes a two byte sequence', function() {
         'the value is written');
         'the value is written');
 });
 });
 
 
+test('writeBytes grows the internal byte array dynamically', function() {
+  var
+    tag = new FlvTag(FlvTag.VIDEO_TAG),
+    tooManyBytes = new Uint8Array(tag.bytes.byteLength + 1);
+
+  try {
+    tag.writeBytes(tooManyBytes);
+    ok(true, 'the buffer grew to fit the data');
+  } catch(e) {
+    ok(!e, 'the buffer should grow');
+  }
+});
+
 })(this);  
 })(this);