Be more forgiving about incompatibilities

Allow h.264 codecs to mingle with one another. Only exclude variants based on audio if one or the other is using HE-AAC.

@@ -294,6 +294,27 @@ videojs.Hls.bufferedAdditions_ = function(original, update) {
   return result;
   return result;
 };
 };
 
 
+
+var parseCodecs = function(codecs) {
+  var result = {
+    codecCount: 0,
+    videoCodec: null,
+    audioProfile: null
+  };
+
+  result.codecCount = codecs.split(',').length;
+  result.codecCount = result.codecCount || 2;
+
+  // parse the video codec but ignore the version
+  result.videoCodec = /(^|\s|,)+(avc1)[^ ,]*/i.exec(codecs);
+  result.videoCodec = result.videoCodec && result.videoCodec[2];
+
+  // parse the last field of the audio codec
+  result.audioProfile = /(^|\s|,)+mp4a.\d+\.(\d+)/i.exec(codecs);
+  result.audioProfile = result.audioProfile && result.audioProfile[2];
+
+  return result;
+};
 /**
 /**
  * Blacklist playlists that are known to be codec or
  * Blacklist playlists that are known to be codec or
  * stream-incompatible with the SourceBuffer configuration. For
  * stream-incompatible with the SourceBuffer configuration. For
@@ -307,19 +328,46 @@ videojs.Hls.bufferedAdditions_ = function(original, update) {
  * will be excluded from the default playlist selection algorithm
  * will be excluded from the default playlist selection algorithm
  * indefinitely.
  * indefinitely.
  */
  */
-videojs.HlsHandler.prototype.excludeIncompatibleStreams_ = function(media) {
-  var master = this.playlists.master, codecs = '';
+videojs.HlsHandler.prototype.excludeIncompatibleVariants_ = function(media) {
+  var
+    master = this.playlists.master,
+    codecCount = 2,
+    videoCodec = null,
+    audioProfile = null,
+    codecs;
 
 
   if (media.attributes && media.attributes.CODECS) {
   if (media.attributes && media.attributes.CODECS) {
-    codecs = media.attributes.CODECS;
+    codecs = parseCodecs(media.attributes.CODECS);
+    videoCodec = codecs.videoCodec;
+    audioProfile = codecs.audioProfile;
+    codecCount = codecs.codecCount;
   }
   }
   master.playlists.forEach(function(variant) {
   master.playlists.forEach(function(variant) {
-    var variantCodecs = '';
+    var variantCodecs = {
+      codecCount: 2,
+      videoCodec: null,
+      audioProfile: null
+    };
+
     if (variant.attributes && variant.attributes.CODECS) {
     if (variant.attributes && variant.attributes.CODECS) {
-      variantCodecs = variant.attributes.CODECS;
+      variantCodecs = parseCodecs(variant.attributes.CODECS);
+    }
+
+    // if the streams differ in the presence or absence of audio or
+    // video, they are incompatible
+    if (variantCodecs.codecCount !== codecCount) {
+      variant.excludeUntil = Infinity;
     }
     }
 
 
-    if (variantCodecs !== codecs) {
+    // if h.264 is specified on the current playlist, some flavor of
+    // it must be specified on all compatible variants
+    if (variantCodecs.videoCodec !== videoCodec) {
+      variant.excludeUntil = Infinity;
+    }
+    // HE-AAC ("mp4a.40.5") is incompatible with all other versions of
+    // AAC audio in Chrome 46. Don't mix the two.
+    if ((variantCodecs.audioProfile === '5' && audioProfile !== '5') ||
+        (audioProfile === '5' && variantCodecs.audioProfile !== '5')) {
       variant.excludeUntil = Infinity;
       variant.excludeUntil = Infinity;
     }
     }
   });
   });
@@ -344,7 +392,7 @@ videojs.HlsHandler.prototype.setupSourceBuffer_ = function() {
 
 
   // exclude any incompatible variant streams from future playlist
   // exclude any incompatible variant streams from future playlist
   // selection
   // selection
-  this.excludeIncompatibleStreams_(media);
+  this.excludeIncompatibleVariants_(media);
 
 
   // transition the sourcebuffer to the ended state if we've hit the end of
   // transition the sourcebuffer to the ended state if we've hit the end of
   // the playlist
   // the playlist

@@ -1171,6 +1171,50 @@ test('blacklists switching from video-only playlists to video+audio', function()
   equal(videoAudioPlaylist.excludeUntil, Infinity, 'excluded incompatible playlist');
   equal(videoAudioPlaylist.excludeUntil, Infinity, 'excluded incompatible playlist');
 });
 });
 
 
+test('does not blacklist compatible H.264 codec strings', function() {
+  var master;
+  player.src({
+    src: 'manifest/master.m3u8',
+    type: 'application/vnd.apple.mpegurl'
+  });
+  openMediaSource(player);
+
+  player.tech_.hls.bandwidth = 1;
+  requests.shift().respond(200, null,
+                           '#EXTM3U\n' +
+                           '#EXT-X-STREAM-INF:BANDWIDTH=1,CODECS="avc1.4d400d,mp4a.40.5"\n' +
+                           'media.m3u8\n' +
+                           '#EXT-X-STREAM-INF:BANDWIDTH=10,CODECS="avc1.4d400f,mp4a.40.5"\n' +
+                           'media1.m3u8\n'); // master
+
+  standardXHRResponse(requests.shift()); // media
+  master = player.tech_.hls.playlists.master;
+  strictEqual(master.playlists[0].excludeUntil, undefined, 'did not blacklist');
+  strictEqual(master.playlists[1].excludeUntil, undefined, 'did not blacklist');
+});
+
+test('does not blacklist compatible AAC codec strings', function() {
+  var master;
+  player.src({
+    src: 'manifest/master.m3u8',
+    type: 'application/vnd.apple.mpegurl'
+  });
+  openMediaSource(player);
+
+  player.tech_.hls.bandwidth = 1;
+  requests.shift().respond(200, null,
+                           '#EXTM3U\n' +
+                           '#EXT-X-STREAM-INF:BANDWIDTH=1,CODECS="avc1.4d400d,mp4a.40.2"\n' +
+                           'media.m3u8\n' +
+                           '#EXT-X-STREAM-INF:BANDWIDTH=10,CODECS="avc1.4d400d,mp4a.40.3"\n' +
+                           'media1.m3u8\n'); // master
+
+  standardXHRResponse(requests.shift()); // media
+  master = player.tech_.hls.playlists.master;
+  strictEqual(master.playlists[0].excludeUntil, undefined, 'did not blacklist');
+  strictEqual(master.playlists[1].excludeUntil, undefined, 'did not blacklist');
+});
+
 test('blacklists switching between playlists with incompatible audio codecs', function() {
 test('blacklists switching between playlists with incompatible audio codecs', function() {
   var alternatePlaylist;
   var alternatePlaylist;
   player.src({
   player.src({