Fix discontinuities

Never match media indices on playlist reload based on segment URI because some streams may re-use the same segment in multiple positions. Change fetchKeys() so that it operates on buffered segments instead of directly modifying a version of the playlist. Before that change, live playlists with low segment durations could stall because the key would be applied to the previous version of the live playlist and segments would get blocked up forever in the queue waiting for their key to arrive. Use a much less destructive mechanism for playing across discontinuities. vjs_discontinuity() on the SWF allows us to signal a timestamp discontinuity without flushing the playback buffer. That means we don't have to wait until the buffer is empty when a discontinuity is encountered and feeding data to the SWF doesn't have to block either. Update tests to reflect new key-segment request ordering.

@@ -221,14 +221,13 @@ videojs.Hls.prototype.src = function(src) {
     this.mediaIndex = videojs.Hls.translateMediaIndex(this.mediaIndex, oldMediaPlaylist, updatedPlaylist);
     this.mediaIndex = videojs.Hls.translateMediaIndex(this.mediaIndex, oldMediaPlaylist, updatedPlaylist);
     oldMediaPlaylist = updatedPlaylist;
     oldMediaPlaylist = updatedPlaylist;
 
 
-    this.fetchKeys(updatedPlaylist, this.mediaIndex);
+    this.fetchKeys_();
   }));
   }));
 
 
   this.playlists.on('mediachange', videojs.bind(this, function() {
   this.playlists.on('mediachange', videojs.bind(this, function() {
     // abort outstanding key requests and check if new keys need to be retrieved
     // abort outstanding key requests and check if new keys need to be retrieved
     if (keyXhr) {
     if (keyXhr) {
       this.cancelKeyXhr();
       this.cancelKeyXhr();
-      this.fetchKeys(this.playlists.media(), this.mediaIndex);
     }
     }
 
 
     player.trigger('mediachange');
     player.trigger('mediachange');
@@ -330,11 +329,10 @@ videojs.Hls.prototype.setCurrentTime = function(currentTime) {
   // cancel outstanding requests and buffer appends
   // cancel outstanding requests and buffer appends
   this.cancelSegmentXhr();
   this.cancelSegmentXhr();
 
 
-  // fetch new encryption keys, if necessary
+  // abort outstanding key requests, if necessary
   if (keyXhr) {
   if (keyXhr) {
     keyXhr.aborted = true;
     keyXhr.aborted = true;
     this.cancelKeyXhr();
     this.cancelKeyXhr();
-    this.fetchKeys(this.playlists.media(), this.mediaIndex);
   }
   }
 
 
   // clear out any buffered segments
   // clear out any buffered segments
@@ -659,6 +657,7 @@ videojs.Hls.prototype.loadSegment = function(segmentUri, offset) {
       offset: offset,
       offset: offset,
       bytes: new Uint8Array(this.response)
       bytes: new Uint8Array(this.response)
     });
     });
+    player.trigger('progress');
     tech.drainBuffer();
     tech.drainBuffer();
 
 
     tech.mediaIndex++;
     tech.mediaIndex++;
@@ -700,7 +699,8 @@ videojs.Hls.prototype.drainBuffer = function(event) {
     if (keyFailed(segment.key)) {
     if (keyFailed(segment.key)) {
       return segmentBuffer.shift();
       return segmentBuffer.shift();
     } else if (!segment.key.bytes) {
     } else if (!segment.key.bytes) {
-      return;
+      // trigger a key request if one is not already in-flight
+      return this.fetchKeys_();
     } else {
     } else {
       // if the media sequence is greater than 2^32, the IV will be incorrect
       // if the media sequence is greater than 2^32, the IV will be incorrect
       // assuming 10s segments, that would be about 1300 years
       // assuming 10s segments, that would be about 1300 years
@@ -714,23 +714,6 @@ videojs.Hls.prototype.drainBuffer = function(event) {
   event = event || {};
   event = event || {};
   segmentOffset = videojs.Hls.getPlaylistDuration(playlist, 0, mediaIndex) * 1000;
   segmentOffset = videojs.Hls.getPlaylistDuration(playlist, 0, mediaIndex) * 1000;
 
 
-  // abort() clears any data queued in the source buffer so wait
-  // until it empties before calling it when a discontinuity is
-  // next in the buffer
-  if (segment.discontinuity) {
-    if (event.type === 'waiting') {
-      this.sourceBuffer.abort();
-      // tell the SWF where playback is continuing in the stitched timeline
-      this.el().vjs_setProperty('currentTime', segmentOffset * 0.001);
-    } else if (event.type === 'timeupdate') {
-      return;
-    } else if (typeof offset !== 'number') {
-      //if the discontinuity is reached under normal conditions, ie not a seek,
-      //the buffer already contains data and does not need to be refilled,
-      return;
-    }
-  }
-
   // transmux the segment data from MP2T to FLV
   // transmux the segment data from MP2T to FLV
   this.segmentParser_.parseSegmentBinaryData(bytes);
   this.segmentParser_.parseSegmentBinaryData(bytes);
   this.segmentParser_.flushTags();
   this.segmentParser_.flushTags();
@@ -758,6 +741,12 @@ videojs.Hls.prototype.drainBuffer = function(event) {
     this.lastSeekedTime_ = null;
     this.lastSeekedTime_ = null;
   }
   }
 
 
+  // when we're crossing a discontinuity, inject metadata to indicate
+  // that the decoder should be reset appropriately
+  if (segment.discontinuity && tags.length) {
+    this.el().vjs_discontinuity();
+  }
+
   for (i = 0; i < tags.length; i++) {
   for (i = 0; i < tags.length; i++) {
     // queue up the bytes to be appended to the SourceBuffer
     // queue up the bytes to be appended to the SourceBuffer
     // the queue gives control back to the browser between tags
     // the queue gives control back to the browser between tags
@@ -776,11 +765,19 @@ videojs.Hls.prototype.drainBuffer = function(event) {
   }
   }
 };
 };
 
 
-videojs.Hls.prototype.fetchKeys = function(playlist, index) {
-  var i, key, tech, player, settings, view;
+/**
+ * Attempt to retrieve keys starting at a particular media
+ * segment. This method has no effect if segments are not yet
+ * available or a key request is already in progress.
+ *
+ * @param playlist {object} the media playlist to fetch keys for
+ * @param index {number} the media segment index to start from
+ */
+videojs.Hls.prototype.fetchKeys_ = function() {
+  var i, key, tech, player, settings, segment, view, receiveKey;
 
 
   // if there is a pending XHR or no segments, don't do anything
   // if there is a pending XHR or no segments, don't do anything
-  if (keyXhr || !playlist.segments) {
+  if (keyXhr || !this.segmentBuffer_.length) {
     return;
     return;
   }
   }
 
 
@@ -788,22 +785,19 @@ videojs.Hls.prototype.fetchKeys = function(playlist, index) {
   player = this.player();
   player = this.player();
   settings = player.options().hls || {};
   settings = player.options().hls || {};
 
 
-  // jshint -W083
-  for (i = index; i < playlist.segments.length; i++) {
-    key = playlist.segments[i].key;
-    if (key && !key.bytes && !keyFailed(key)) {
-      keyXhr = videojs.Hls.xhr({
-        url: this.playlistUriToUrl(key.uri),
-        responseType: 'arraybuffer',
-        withCredentials: settings.withCredentials
-      }, function(err, url) {
+  /**
+   * Handle a key XHR response. This function needs to lookup the
+   */
+  receiveKey = function(key) {
+    return function(error) {
       keyXhr = null;
       keyXhr = null;
 
 
-        if (err || !this.response || this.response.byteLength !== 16) {
+      if (error || !this.response || this.response.byteLength !== 16) {
         key.retries = key.retries || 0;
         key.retries = key.retries || 0;
         key.retries++;
         key.retries++;
         if (!this.aborted) {
         if (!this.aborted) {
-            tech.fetchKeys(playlist, i);
+          // try fetching again
+          tech.fetchKeys_();
         }
         }
         return;
         return;
       }
       }
@@ -815,12 +809,31 @@ videojs.Hls.prototype.fetchKeys = function(playlist, index) {
         view.getUint32(8),
         view.getUint32(8),
         view.getUint32(12)
         view.getUint32(12)
       ]);
       ]);
-        tech.fetchKeys(playlist, i++, url);
-      });
+
+      // check to see if this allows us to make progress buffering now
+      tech.checkBuffer_();
+    };
+  };
+
+  for (i = 0; i < tech.segmentBuffer_.length; i++) {
+    segment = tech.segmentBuffer_[i].playlist.segments[tech.segmentBuffer_[i].mediaIndex];
+    key = segment.key;
+
+    // continue looking if this segment is unencrypted
+    if (!key) {
+      continue;
+    }
+
+    // request the key if the retry limit hasn't been reached
+    if (!key.bytes && !keyFailed(key)) {
+      keyXhr = videojs.Hls.xhr({
+        url: this.playlistUriToUrl(key.uri),
+        responseType: 'arraybuffer',
+        withCredentials: settings.withCredentials
+      }, receiveKey(key));
       break;
       break;
     }
     }
   }
   }
-  // jshint +W083
 };
 };
 
 
 /**
 /**
@@ -925,9 +938,7 @@ videojs.Hls.getPlaylistTotalDuration = function(playlist) {
  * playlist
  * playlist
  */
  */
 videojs.Hls.translateMediaIndex = function(mediaIndex, original, update) {
 videojs.Hls.translateMediaIndex = function(mediaIndex, original, update) {
-  var i,
-      originalSegment,
-      translatedMediaIndex;
+  var translatedMediaIndex;
 
 
   // no segments have been loaded from the original playlist
   // no segments have been loaded from the original playlist
   if (mediaIndex === 0) {
   if (mediaIndex === 0) {
@@ -939,15 +950,8 @@ videojs.Hls.translateMediaIndex = function(mediaIndex, original, update) {
     return 0;
     return 0;
   }
   }
 
 
-  // try to sync based on URI
-  i = update.segments.length;
-  originalSegment = original.segments[mediaIndex - 1];
-  while (i--) {
-    if (originalSegment.uri === update.segments[i].uri) {
-      return i + 1;
-    }
-  }
-
+  // translate based on media sequence numbers. syncing up across
+  // bitrate switches should be happening here.
   translatedMediaIndex = (mediaIndex + (original.mediaSequence - update.mediaSequence));
   translatedMediaIndex = (mediaIndex + (original.mediaSequence - update.mediaSequence));
 
 
   if (translatedMediaIndex >= update.segments.length || translatedMediaIndex < 0) {
   if (translatedMediaIndex >= update.segments.length || translatedMediaIndex < 0) {
@@ -955,7 +959,6 @@ videojs.Hls.translateMediaIndex = function(mediaIndex, original, update) {
     return videojs.Hls.getMediaIndexForLive_(update) + 1;
     return videojs.Hls.getMediaIndexForLive_(update) + 1;
   }
   }
 
 
-  // sync on media sequence
   return translatedMediaIndex;
   return translatedMediaIndex;
 };
 };